Convert msgspec schemas to Schema.from_dict format#929
Draft
ahal wants to merge 8 commits intotaskcluster:mainfrom
Draft
Convert msgspec schemas to Schema.from_dict format#929ahal wants to merge 8 commits intotaskcluster:mainfrom
Schema.from_dict format#929ahal wants to merge 8 commits intotaskcluster:mainfrom
Conversation
Collaborator
Author
|
This isn't ready for review yet, but posting it for early feedback as I need to focus on other things for now. |
ahal
commented
Apr 8, 2026
| # Information for indexing this build so its artifacts can be discovered. | ||
| "index": (IndexSchema, None), | ||
| # Whether this image should be cached based on inputs. | ||
| "cache": (bool, None), |
Collaborator
Author
There was a problem hiding this comment.
TODO: these should be using Optional
ahal
force-pushed
the
ahal/push-xpqpvswlroun
branch
from
b9d4a44 to
4b61b91
Compare
ahal
force-pushed
the
ahal/push-xpqpvswlroun
branch
from
4b61b91 to
b3fad09
Compare
ahal
changed the title
Schema.from_dict format
ahal
force-pushed
the
ahal/push-xpqpvswlroun
branch
from
b3fad09 to
d510d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Msgspec is awesome, but the new class based method of defining schemas is clunky and more importantly, doesn't support kebab case (dashes in the key name).
This means users need to mentally translate
_in the schema to-in the task. It's also not possible to have a mix of underscores and dashes (which is probably a good thing.. but sometimes you want to forward subsections of a task definition to systems out of your control).